-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40995/#review109324
-----------------------------------------------------------


One thing we also agreed is to disallow empty string roles. Do you think it 
makes sense to extend this patch with a test for that or do it separately?


src/tests/role_tests.cpp (line 36)
<https://reviews.apache.org/r/40995/#comment168798>

    I believe we use third person singular in such cases.



src/tests/role_tests.cpp (lines 76 - 77)
<https://reviews.apache.org/r/40995/#comment168802>

    I think a comment here expaining why you reduce the allocation interval 
will be good for posterity. Alternatively, you can use 
`Clock::advance(flags.allocation_interval)` before `AWAIT_READY(offers)` to 
achieve the same. Perhaps it's a cleaner solution.



src/tests/role_tests.cpp (lines 83 - 84)
<https://reviews.apache.org/r/40995/#comment168799>

    `MesosTest` exposes the `defaultAgentResourcesString` constant. I think you 
can get rid of these lines in order not to distract the user and make sure 
`unreserved` is contained in `defaultAgentResourcesString` later in the code:
    ```
    
EXPECT_TRUE(Resources::parse(defaultAgentResourcesString).get().contains(unreserved));
    ```



src/tests/role_tests.cpp (line 172)
<https://reviews.apache.org/r/40995/#comment168801>

    Backticks?


- Alexander Rukletsov


On Dec. 8, 2015, 8:28 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40995/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2015, 8:28 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, and Yong 
> Qiao Wang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test cases for role behavior.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am e96e0ec41e11acff00fbfb3e86427b48a0625bd2 
>   src/tests/reservation_tests.cpp 3fdf5e121840fe99057e917cca48f1425eff6624 
>   src/tests/role_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40995/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Reply via email to