> On Dec. 8, 2015, 12:51 a.m., Guangya Liu wrote: > > src/tests/role_tests.cpp, lines 24-27 > > <https://reviews.apache.org/r/40995/diff/1/?file=1154161#file1154161line24> > > > > I think that we should always use std first? > > > > using std::vector; > > > > using process::Future; > > using process::PID; > > Neil Conway wrote: > All the test cases I looked at place `process` before `std`: e.g., > `fault_tolerance_tests.cpp`, `master_tests.cpp`, `reservation_tests.cpp`. > > Guangya Liu wrote: > I think that there are bugs here, you can also refer to > master_quota_test.cpp , I recalled that I discussed with alex-mesos for this > issue and his comments is we should put std first. > > Neil Conway wrote: > Can you open a JIRA for this? ISTM we aren't consistent right now, and as > far as I can tell, the style guide doesn't say anything about the order of > `using` directives. > > Guangya Liu wrote: > Filed a JIRA here https://issues.apache.org/jira/browse/MESOS-4093 Thanks!
We are not consistent (I think we do 50 / 50 now), but we try to become one day : ). An argument for putting `std` first is because we do the same for includes. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40995/#review109234 ----------------------------------------------------------- On Dec. 8, 2015, 8:28 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40995/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2015, 8:28 a.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, and Yong > Qiao Wang. > > > Repository: mesos > > > Description > ------- > > Added test cases for role behavior. > > > Diffs > ----- > > src/Makefile.am e96e0ec41e11acff00fbfb3e86427b48a0625bd2 > src/tests/reservation_tests.cpp 3fdf5e121840fe99057e917cca48f1425eff6624 > src/tests/role_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/40995/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Neil Conway > >
