-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39043/#review109249
-----------------------------------------------------------


Bad patch!

Reviews applied: [40539, 37999, 38000, 38094, 38950]

Failed command: ./support/apply-review.sh -n -r 38950

Error:
 2015-12-08 01:54:53 URL:https://reviews.apache.org/r/38950/diff/raw/ 
[19796/19796] -> "38950.patch" [1]
Successfully applied: Http Authenticators can be loaded as modules from mesos.

Adds support for modularization of HTTP Authenticators. 

It includes an example of how to do it with the Basic HTTP Authenticator.


Review: https://reviews.apache.org/r/38950
src/examples/test_http_authenticator_module.cpp:1:  A license header should 
appear on the file's  first line starting with '// Licensed'.: /**
src/authentication/http/basic_authenticator_factory.cpp:1:  A license header 
should appear on the file's  first line starting with '// Licensed'.: /**
include/mesos/authentication/http/basic_authenticator_factory.hpp:1:  A license 
header should appear on the file's  first line starting with '// Licensed'.: /**
include/mesos/module/http_authenticator.hpp:1:  A license header should appear 
on the file's  first line starting with '// Licensed'.: /**
src/tests/http_authentication_tests.cpp:1:  A license header should appear on 
the file's  first line starting with '// Licensed'.: /**
Total errors found: 5
Checking 10 files
Failed to commit patch

- Mesos ReviewBot


On Dec. 7, 2015, 2:22 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39043/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2015, 2:22 p.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3756
>     https://issues.apache.org/jira/browse/MESOS-3756
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> 1. Adds a flag to load an HTTP Authenticator module from the flags.
> 2. If provided, uses the credentials file to initialize the default HTTP 
> Authenticator.
> 3. Updates the existing endpoints which implement their own basic HTTP 
> authenticator with the libprocess one.
> 4. Updates one test which expected the wrong results since now credentials 
> are checked before the body of the request.
> 
> 
> Diffs
> -----
> 
>   src/master/constants.hpp cc38dfcf57ecbc8555379084acbf2bfa4b3fc759 
>   src/master/constants.cpp 98ea7c8f1e7c3057cfe941f82f1b71f7731a8f32 
>   src/master/flags.hpp 9af6c68eef6bcf39d5776809fab6c66dc95da6b2 
>   src/master/flags.cpp f9223edb33483cb5619e7dd75221f735306462c6 
>   src/master/http.cpp 9097eda47558fb5306af5a61b464937d7ab34e83 
>   src/master/master.hpp 4683fa542a740f9a0b80fff7fbe0e63ec66266f2 
>   src/master/master.cpp 953fa4f14929581b226a7e27d30aea7a5aa1fd7c 
> 
> Diff: https://reviews.apache.org/r/39043/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Reply via email to