----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ -----------------------------------------------------------
(Updated Nov. 17, 2015, 2:37 p.m.) Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, and Till Toenshoff. Changes ------- Third round of reviews. Bugs: MESOS-3756 https://issues.apache.org/jira/browse/MESOS-3756 Repository: mesos Description ------- 1. Adds a flag to load an HTTP Authenticator module from the flags. 2. If provided, uses the credentials file to initialize the default HTTP Authenticator. 3. Updates the existing endpoints which implement their own basic HTTP authenticator with the libprocess one. 4. Updates one test which expected the wrong results since now credentials are checked before the body of the request. Diffs (updated) ----- src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2 src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09 src/master/flags.hpp 5fd5d502697b2edc22ae98a5a8e361bf62bf8bb6 src/master/flags.cpp 806e2da6ad37a6acf76818d4c6b3c462175fd09d src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28 Diff: https://reviews.apache.org/r/39043/diff/ Testing ------- make check Thanks, Alexander Rojas