----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review105788 -----------------------------------------------------------
Patch looks great! Reviews applied: [39276, 37998, 37999, 38000, 38094, 38627, 38950, 39043] All tests passed. - Mesos ReviewBot On Nov. 10, 2015, 4:03 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39043/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2015, 4:03 a.m.) > > > Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, and Till > Toenshoff. > > > Bugs: MESOS-3756 > https://issues.apache.org/jira/browse/MESOS-3756 > > > Repository: mesos > > > Description > ------- > > 1. Adds a flag to load an HTTP Authenticator module from the flags. > 2. If provided, uses the credentials file to initialize the default HTTP > Authenticator. > 3. Updates the existing endpoints which implement their own basic HTTP > authenticator with the libprocess one. > 4. Updates one test which expected the wrong results since now credentials > are checked before the body of the request. > > > Diffs > ----- > > src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2 > src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09 > src/master/flags.hpp 5fd5d502697b2edc22ae98a5a8e361bf62bf8bb6 > src/master/flags.cpp 806e2da6ad37a6acf76818d4c6b3c462175fd09d > src/master/http.cpp b0bec97ee69413bb70c2673c4ae49e74988796bf > src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 > src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 > > Diff: https://reviews.apache.org/r/39043/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
