> On Nov. 5, 2015, 11:59 p.m., Neil Conway wrote:
> > include/mesos/roles.hpp, line 51
> > <https://reviews.apache.org/r/35711/diff/15/?file=1089392#file1089392line51>
> >
> >     Should this be a member function? i.e., not static.

When I write this, I refer to the static validate method in Resources. Is it 
better to make it as a member function?


> On Nov. 5, 2015, 11:59 p.m., Neil Conway wrote:
> > include/mesos/roles.hpp, line 53
> > <https://reviews.apache.org/r/35711/diff/15/?file=1089392#file1089392line53>
> >
> >     Is this necessary?

Because we have `Resources() {}`, I still keep it here.


> On Nov. 5, 2015, 11:59 p.m., Neil Conway wrote:
> > include/mesos/roles.hpp, line 59
> > <https://reviews.apache.org/r/35711/diff/15/?file=1089392#file1089392line59>
> >
> >     Is this necessary?

ditto


> On Nov. 5, 2015, 11:59 p.m., Neil Conway wrote:
> > include/mesos/roles.hpp, line 61
> > <https://reviews.apache.org/r/35711/diff/15/?file=1089392#file1089392line61>
> >
> >     Is this necessary?

ditto


> On Nov. 5, 2015, 11:59 p.m., Neil Conway wrote:
> > include/mesos/roles.hpp, line 63
> > <https://reviews.apache.org/r/35711/diff/15/?file=1089392#file1089392line63>
> >
> >     Is this necessary?

ditto


> On Nov. 5, 2015, 11:59 p.m., Neil Conway wrote:
> > src/common/roles.cpp, line 67
> > <https://reviews.apache.org/r/35711/diff/15/?file=1089395#file1089395line67>
> >
> >     Error message is inaccurate.

`inaccurate` means we should change `invalid` to `illegal`, or what description 
would be better here?


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/#review105316
-----------------------------------------------------------


On Dec. 12, 2015, 2:29 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35711/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2015, 2:29 p.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, and Michael Park.
> 
> 
> Bugs: MESOS-2210
>     https://issues.apache.org/jira/browse/MESOS-2210
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Disallow special characters in role name.
> 
> 
> Diffs
> -----
> 
>   include/mesos/roles.hpp PRE-CREATION 
>   src/CMakeLists.txt 0d46043dd06007f2cba56626c82e8edd251cb8fb 
>   src/Makefile.am 9762f8567e32d70b8df2d694a1fef5c692fc730e 
>   src/common/resources.cpp 5a7981744726a0544435cbbd5007487a43a01211 
>   src/common/roles.cpp PRE-CREATION 
>   src/master/flags.cpp f9223edb33483cb5619e7dd75221f735306462c6 
>   src/master/master.hpp 9aa548aa6e159046c94e4ec96f631ea8b3bfd5d8 
>   src/master/master.cpp 0d1482279c68f2a4a27dabaf28774769a5d515c4 
>   src/slave/flags.cpp c4343ab7ff7b7b4d2c335119d41319b0779d2806 
>   src/tests/resources_tests.cpp ce47bac73937a6a608016f46121137d6116c1399 
>   src/tests/roles_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35711/diff/
> 
> 
> Testing
> -------
> 
> make -j8 check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to