-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/#review110461
-----------------------------------------------------------


Thanks for reviving this, and sorry it's taken so long to get back to it.


include/mesos/roles.hpp (line 43)
<https://reviews.apache.org/r/35711/#comment170388>

    We may have additional constraints when we have to create directories in 
Windows based on role names.
    Maybe @hausdorff can tell us more.



src/common/roles.cpp (lines 47 - 49)
<https://reviews.apache.org/r/35711/#comment170383>

    Or empty string?



src/master/flags.cpp (lines 17 - 23)
<https://reviews.apache.org/r/35711/#comment170391>

    Why did these includes need to be added?



src/master/master.hpp (line 31)
<https://reviews.apache.org/r/35711/#comment170392>

    Why add the include?



src/slave/flags.cpp (line 24)
<https://reviews.apache.org/r/35711/#comment170396>

    Why the include?



src/tests/roles_tests.cpp (line 55)
<https://reviews.apache.org/r/35711/#comment170401>

    +1 to Greg's grammar check.



src/tests/roles_tests.cpp (line 57)
<https://reviews.apache.org/r/35711/#comment170399>

    s/vaildate/validate/



src/tests/roles_tests.cpp (line 66)
<https://reviews.apache.org/r/35711/#comment170402>

    Empty string should error.


- Adam B


On Dec. 12, 2015, 6:33 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35711/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2015, 6:33 a.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, and Michael Park.
> 
> 
> Bugs: MESOS-2210
>     https://issues.apache.org/jira/browse/MESOS-2210
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Disallow special characters in role name.
> 
> 
> Diffs
> -----
> 
>   include/mesos/roles.hpp PRE-CREATION 
>   src/CMakeLists.txt 0d46043dd06007f2cba56626c82e8edd251cb8fb 
>   src/Makefile.am 9762f8567e32d70b8df2d694a1fef5c692fc730e 
>   src/common/resources.cpp 5a7981744726a0544435cbbd5007487a43a01211 
>   src/common/roles.cpp PRE-CREATION 
>   src/master/flags.cpp f9223edb33483cb5619e7dd75221f735306462c6 
>   src/master/master.hpp 9aa548aa6e159046c94e4ec96f631ea8b3bfd5d8 
>   src/master/master.cpp 0d1482279c68f2a4a27dabaf28774769a5d515c4 
>   src/slave/flags.cpp c4343ab7ff7b7b4d2c335119d41319b0779d2806 
>   src/tests/resources_tests.cpp ce47bac73937a6a608016f46121137d6116c1399 
>   src/tests/roles_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35711/diff/
> 
> 
> Testing
> -------
> 
> make -j8 check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to