----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39583/#review110325 -----------------------------------------------------------
Ship it! Let's use snake_case in stout. 3rdparty/libprocess/3rdparty/stout/include/Makefile.am (line 142) <https://reviews.apache.org/r/39583/#comment170142> We're now missing `stout/errorbase.hpp` - Joris Van Remoortere On Dec. 12, 2015, 11:08 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39583/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2015, 11:08 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Bugs: MESOS-4110 > https://issues.apache.org/jira/browse/MESOS-4110 > > > Repository: mesos > > > Description > ------- > > Windows: Added `WindowsError` to parallel `ErrnoError`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > a25e2c1e5584e744c666bbc654eafbfc5f7b10e6 > 3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp > 605c23bb9273f12dabbd2d6fa87ca0b06d9958ca > 3rdparty/libprocess/3rdparty/stout/include/stout/errorbase.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp > 9e3b007d9f8db1e16c1f6928d85c230612741cc0 > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/39583/diff/ > > > Testing > ------- > > `make check` from autotools on Ubuntu 15. > `make check` from CMake on OS X 10.10. > Ran `check` project in VS on Windows 10. > > > Thanks, > > Alex Clemmer > >
