----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40347/#review110525 -----------------------------------------------------------
Ship it! src/master/quota_handler.cpp (lines 330 - 333) <https://reviews.apache.org/r/40347/#comment170444> Do you think `principal = credential.isSome() ? credential.get().principal() : None();` would be more concise here? - Greg Mann On Dec. 15, 2015, 11:07 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40347/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 11:07 a.m.) > > > Review request for mesos, Alexander Rukletsov, Alexander Rojas, Joris Van > Remoortere, and Till Toenshoff. > > > Bugs: MESOS-3862 > https://issues.apache.org/jira/browse/MESOS-3862 > > > Repository: mesos > > > Description > ------- > > Quota: Implemented quota request authorization. > > > Diffs > ----- > > src/master/master.hpp 9aa548aa6e159046c94e4ec96f631ea8b3bfd5d8 > src/master/quota_handler.cpp 11167879b2480d9c8dd6398ca39c479089ec2272 > > Diff: https://reviews.apache.org/r/40347/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
