> On Dec. 14, 2015, 7:47 a.m., Qian Zhang wrote: > > include/mesos/executor/executor.proto, line 96 > > <https://reviews.apache.org/r/41275/diff/1/?file=1160521#file1160521line96> > > > > Just a quicky question, how will agent fill this field when it asks the > > executor to shutdown? Is this something that executor itself can > > decide/configure? Or it is a per-slave configuration via slave command line > > option? > > Anand Mazumdar wrote: > The agent can fill this field when it asks the executor to shutdown i.e. > ( via the `Event::Shutdown` message ). The value of this field can be set via > a slave command line option. > > Currently, the existing executor library implementation just uses a > hard-coded value > https://github.com/apache/mesos/blob/master/src/exec/exec.cpp#L83
Thanks Anand. And will we consider to fill this field per-framework? E.g., let framework set it in its FrameworkInfo when it register master since different framework may want different shutdown grace period for its executor. And in master, we can set a max grace period which is used to ensure the value set by framework is not too large. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41275/#review110143 ----------------------------------------------------------- On Dec. 12, 2015, 7:51 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41275/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2015, 7:51 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-3550 > https://issues.apache.org/jira/browse/MESOS-3550 > > > Repository: mesos > > > Description > ------- > > This change introduces a field `grace_period_seconds` that specifies the time > an agent would wait for the executor to terminate before forcefully > destroying the container. > > > Diffs > ----- > > include/mesos/executor/executor.proto > 8f97ad8952b3156e9c299a5a297693c8d2ffccd4 > include/mesos/v1/executor/executor.proto > 7eaa40bf38845befeba477d074396e7660a7b231 > > Diff: https://reviews.apache.org/r/41275/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
