> On Dec. 21, 2015, 3:20 p.m., Greg Mann wrote: > > include/mesos/authorizer/authorizer.hpp, lines 129-131 > > <https://reviews.apache.org/r/41444/diff/3/?file=1173896#file1173896line129> > > > > Though I know what you're saying here, this one sounds a bit confusing > > to me. I wonder if something more concise like "shut down a framework > > registered by another framework principal." might be clearer? > > Alexander Rukletsov wrote: > I reworded it a bit, but not exactly how you proposed. Mind taking a > second look?
FTFY - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41444/#review111528 ----------------------------------------------------------- On Dec. 24, 2015, 7:32 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41444/ > ----------------------------------------------------------- > > (Updated Dec. 24, 2015, 7:32 a.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Greg Mann, Jan Schlicht, > and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > Extract a repetitive part of the function comments into a class comment. > Added backticks, quotes when necessary, formatted comments to avoid > jaggedness. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.hpp > 19f6e1a2d025bf6ff07f515b10d41e8a48d7d0b4 > src/master/main.cpp e00f878770f3e0bddae5a137b50a00822d154e2c > > Diff: https://reviews.apache.org/r/41444/diff/ > > > Testing > ------- > > None: not a functional change. > > > Thanks, > > Alexander Rukletsov > >
