----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41896/#review112882 -----------------------------------------------------------
Ship it! LGTM! (modulo the remaining TODO) docs/app-framework-development-guide.md (line 132) <https://reviews.apache.org/r/41896/#comment173357> Inter-doc links are usually written like: /documentation/latest/high-availability-framework-guide/ Do you want to change all these links to `*.md` (which would work better when viewed on Github)? docs/high-availability-framework-guide.md (line 61) <https://reviews.apache.org/r/41896/#comment173365> Is the exception how Mesos has some acknowledge/resend logic for status updates? (Also, do you plan to complete this TODO before this doc is committed?) docs/high-availability-framework-guide.md (line 174) <https://reviews.apache.org/r/41896/#comment173372> Nit: Denote flags with a leading `--`, to make them more flag-like. Ditto for a couple instances below. - Joseph Wu On Jan. 4, 2016, 10:43 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41896/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2016, 10:43 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Joris Van > Remoortere. > > > Bugs: MESOS-3936 > https://issues.apache.org/jira/browse/MESOS-3936 > > > Repository: mesos > > > Description > ------- > > Added guide to writing highly available Mesos frameworks. > > > Diffs > ----- > > docs/app-framework-development-guide.md > 4a43a93d080bdac37b8aee91748fea7552a1cc67 > docs/high-availability-framework-guide.md PRE-CREATION > docs/high-availability.md 31aa66220617a3f8606b185ef247c11f00735227 > docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535 > > Diff: https://reviews.apache.org/r/41896/diff/ > > > Testing > ------- > > Previewed via site-docker. > > Note that there's a lot more that could be said here; also, at some point we > should probably unify the "reconciliation" page with this page, and perhaps > move some of the content in the "high-availability" page here (leaving the > "high-availability" page for the operator-centric parts of configuring Mesos > to run in HA mode). > > > Thanks, > > Neil Conway > >
