-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41870/#review113236
-----------------------------------------------------------


Bad patch!

Reviews applied: [42015, 41870]

Failed command: ./support/apply-review.sh -n -r 41870

Error:
 2016-01-07 11:12:44 URL:https://reviews.apache.org/r/41870/diff/raw/ [915/915] 
-> "41870.patch" [1]
Total errors found: 0
Checking 1 files
Error: Commit message summary (the first line) must start with a capital letter.

- Mesos ReviewBot


On Jan. 7, 2016, 4:47 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41870/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2016, 4:47 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This trivial change adds ref-qualifiers introduced in C++11 to Option::get(). 
> This is in sync with what boost/folly `optional` already have.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
> b58350b312c1969aa86ec679e95af0f97846c141 
> 
> Diff: https://reviews.apache.org/r/41870/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Verified this enables operations like the following to incur a move instead 
> of a copy:
> 
> ```
> Option<T> create();
> T t = create().get();
> ```
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Reply via email to