----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41870/#review114764 -----------------------------------------------------------
Ship it! Ship It! - Joris Van Remoortere On Jan. 13, 2016, 8:12 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41870/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2016, 8:12 p.m.) > > > Review request for mesos, Joris Van Remoortere and Michael Park. > > > Repository: mesos > > > Description > ------- > > This trivial change adds ref-qualifiers introduced in C++11 to Option::get(). > This is in sync with what boost/folly `optional` already have. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp > b58350b312c1969aa86ec679e95af0f97846c141 > > Diff: https://reviews.apache.org/r/41870/diff/ > > > Testing > ------- > > make check > > Verified this enables operations like the following to incur a move instead > of a copy: > > ``` > Option<T> create(); > T t = create().get(); > ``` > > > Thanks, > > Anand Mazumdar > >
