-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40632/#review113303
-----------------------------------------------------------


I haven't taken a close look at the tests yet.  However, it may benefit you to 
add tests (preferably in separate reviews) for:

+ Dynamic reservations + optimistic offers.  Make sure the new reservations 
show up as allocation slack.
+ Oversubscription + optimistic offers.  Make sure neither overwrites the other.
+ Quota + optimistic offers.


src/master/allocator/mesos/hierarchical.cpp (lines 438 - 443)
<https://reviews.apache.org/r/40632/#comment173841>

    Resources can be dynamically reserved, so ideally, you should recalculating 
the allocation slack in someplace like `updateAllocation`.  The `RESERVE` 
operation specifically increases allocation slack.



src/master/allocator/mesos/hierarchical.cpp (line 516)
<https://reviews.apache.org/r/40632/#comment173835>

    The Oversubscription logic here will overwrite anything you've done in 
`::addSlave`.



src/master/allocator/mesos/hierarchical.cpp (lines 1305 - 1313)
<https://reviews.apache.org/r/40632/#comment173846>

    If you make the changes above, this recalculation will be unnecessary.  
`resources.allocationSlack()` should be sufficient.



src/master/allocator/mesos/hierarchical.cpp (lines 1343 - 1360)
<https://reviews.apache.org/r/40632/#comment173855>

    There would be less code duplication if you did something like:
    ```
    if (!remainingAllocationSlack.empty()) {
      resources = remainingAllocationSlack;
    } else {
      continue;
    }
    ```


- Joseph Wu


On Jan. 7, 2016, 3:27 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40632/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2016, 3:27 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4145
>     https://issues.apache.org/jira/browse/MESOS-4145
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enabled oversubscribed resources for reservations in allocator.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f 
>   src/tests/hierarchical_allocator_tests.cpp 
> e044f832c2c16e53e663c6ced5452649bb0dcb59 
> 
> Diff: https://reviews.apache.org/r/40632/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Reply via email to