> On 一月 7, 2016, 6:55 a.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1350 > > <https://reviews.apache.org/r/40632/diff/10/?file=1180362#file1180362line1350> > > > > It does not include `ALLOCATIONS_SLACK` in `remainingClusterResources`; > > so if account `remainingAllocationSlack` in `allocatedForWDRF`, the check > > of `remainingClusterResources.contains(allocatedForWDRF + resources)` will > > be always false.
The `remainingClusterResources` DOES include all revocable resoruces including both usgae slack and allocation slack. Please refer to https://github.com/apache/mesos/blob/master/src/master/allocator/mesos/hierarchical.cpp#L1220-L1224 - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/#review113193 ----------------------------------------------------------- On 一月 3, 2016, 9:21 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40632/ > ----------------------------------------------------------- > > (Updated 一月 3, 2016, 9:21 a.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van > Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu. > > > Bugs: MESOS-4145 > https://issues.apache.org/jira/browse/MESOS-4145 > > > Repository: mesos > > > Description > ------- > > Enabled oversubscribed resources for reservations in allocator. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 7f900c4e024485704d79e57ae22407557598fe6c > src/tests/hierarchical_allocator_tests.cpp > e044f832c2c16e53e663c6ced5452649bb0dcb59 > > Diff: https://reviews.apache.org/r/40632/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
