> On Jan. 7, 2016, 12:22 p.m., Joseph Wu wrote: > > I haven't taken a close look at the tests yet. However, it may benefit you > > to add tests (preferably in separate reviews) for: > > > > + Dynamic reservations + optimistic offers. Make sure the new reservations > > show up as allocation slack. > > + Oversubscription + optimistic offers. Make sure neither overwrites the > > other. > > + Quota + optimistic offers.
Oops, I didn't notice that the next few reviews do some of this already. Can you add a note to the "Testing Done" and "Description" saying that the changes to allocator are spread out over several reviews? - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/#review113303 ----------------------------------------------------------- On Jan. 7, 2016, 3:27 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40632/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2016, 3:27 a.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van > Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu. > > > Bugs: MESOS-4145 > https://issues.apache.org/jira/browse/MESOS-4145 > > > Repository: mesos > > > Description > ------- > > Enabled oversubscribed resources for reservations in allocator. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f > src/tests/hierarchical_allocator_tests.cpp > e044f832c2c16e53e663c6ced5452649bb0dcb59 > > Diff: https://reviews.apache.org/r/40632/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
