----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review113644 -----------------------------------------------------------
Ship it! Looks good to me. We can commit this once you've resolved any remaining issues (from Klaus, etc.) include/mesos/roles.hpp (line 33) <https://reviews.apache.org/r/35711/#comment174402> s/otherwise return/otherwise a/ include/mesos/roles.hpp (line 54) <https://reviews.apache.org/r/35711/#comment174404> "Error if validation fails for any role, None otherwise." src/tests/role_tests.cpp (line 602) <https://reviews.apache.org/r/35711/#comment174410> s/function/functions/ - Adam B On Jan. 9, 2016, 3:15 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35711/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2016, 3:15 a.m.) > > > Review request for mesos, Adam B, Jie Yu, and Michael Park. > > > Bugs: MESOS-2210 > https://issues.apache.org/jira/browse/MESOS-2210 > > > Repository: mesos > > > Description > ------- > > Disallow special characters in role name. > > > Diffs > ----- > > docs/roles.md af1adad7ec8122fd10f7de44848014b850416bcd > include/mesos/roles.hpp PRE-CREATION > src/Makefile.am bbd0c119321fa9d11fea61b140428dd92d1258c8 > src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 > src/common/roles.cpp PRE-CREATION > src/master/master.cpp 2d9b7f9540574aa3ef9e5af3b2b8922dffeebac8 > src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 > src/tests/role_tests.cpp 373ae267b85588fe491ab0a0ce8aa195f971aac3 > > Diff: https://reviews.apache.org/r/35711/diff/ > > > Testing > ------- > > make -j8 check > > > Thanks, > > haosdent huang > >
