----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review113639 -----------------------------------------------------------
include/mesos/roles.hpp (line 51) <https://reviews.apache.org/r/35711/#comment174396> Would you highlight which case is considered not valid? anyone of them is not valid or all of them are not valid? src/common/roles.cpp (line 32) <https://reviews.apache.org/r/35711/#comment174400> Do we need to define a const value `REOLE_SPLITOR` to replace ','? src/common/roles.cpp (line 34) <https://reviews.apache.org/r/35711/#comment174397> Do we need to check whether duplicated roles here? src/common/roles.cpp (lines 56 - 63) <https://reviews.apache.org/r/35711/#comment174399> Just another question about the role: do we support other language, e.g. Chinese? If not, I'd suggest also to highlight in document. src/common/roles.cpp (line 64) <https://reviews.apache.org/r/35711/#comment174398> I'm not sure whether this will introduce porting issue: for the whitespace, it's better to use C std (isspace) lib to check. - Klaus Ma On Jan. 9, 2016, 7:15 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35711/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2016, 7:15 p.m.) > > > Review request for mesos, Adam B, Jie Yu, and Michael Park. > > > Bugs: MESOS-2210 > https://issues.apache.org/jira/browse/MESOS-2210 > > > Repository: mesos > > > Description > ------- > > Disallow special characters in role name. > > > Diffs > ----- > > docs/roles.md af1adad7ec8122fd10f7de44848014b850416bcd > include/mesos/roles.hpp PRE-CREATION > src/Makefile.am bbd0c119321fa9d11fea61b140428dd92d1258c8 > src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 > src/common/roles.cpp PRE-CREATION > src/master/master.cpp 2d9b7f9540574aa3ef9e5af3b2b8922dffeebac8 > src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 > src/tests/role_tests.cpp 373ae267b85588fe491ab0a0ce8aa195f971aac3 > > Diff: https://reviews.apache.org/r/35711/diff/ > > > Testing > ------- > > make -j8 check > > > Thanks, > > haosdent huang > >
