> On Jan. 9, 2016, 11:44 p.m., Klaus Ma wrote: > > src/common/roles.cpp, line 32 > > <https://reviews.apache.org/r/35711/diff/22/?file=1189198#file1189198line32> > > > > Do we need to define a const value `REOLE_SPLITOR` to replace ','? > > Adam B wrote: > I think it's unnecessary, since this is the only place it's used. If we > ever decide to make this configurable, we can break it out then.
Now that I think about it, we could even just inline `parse()` into the one place it's used in `master.cpp`, since it's really just a `tokenize()` followed by a `validate()`. Up to you, haosdent. I'm fine with leaving `parse()` alone too. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review113639 ----------------------------------------------------------- On Jan. 9, 2016, 3:15 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35711/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2016, 3:15 a.m.) > > > Review request for mesos, Adam B, Jie Yu, and Michael Park. > > > Bugs: MESOS-2210 > https://issues.apache.org/jira/browse/MESOS-2210 > > > Repository: mesos > > > Description > ------- > > Disallow special characters in role name. > > > Diffs > ----- > > docs/roles.md af1adad7ec8122fd10f7de44848014b850416bcd > include/mesos/roles.hpp PRE-CREATION > src/Makefile.am bbd0c119321fa9d11fea61b140428dd92d1258c8 > src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 > src/common/roles.cpp PRE-CREATION > src/master/master.cpp 2d9b7f9540574aa3ef9e5af3b2b8922dffeebac8 > src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 > src/tests/role_tests.cpp 373ae267b85588fe491ab0a0ce8aa195f971aac3 > > Diff: https://reviews.apache.org/r/35711/diff/ > > > Testing > ------- > > make -j8 check > > > Thanks, > > haosdent huang > >
