----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42121/ -----------------------------------------------------------
Review request for mesos, Ben Mahler and Joris Van Remoortere. Repository: mesos Description ------- Using `Clock::settle()` does not provide the synchronization that "MetricsTest.SnapshotTimeout" requires. Of course, using `os::sleep()` is not right either, but at least it is more honest than using `Clock::settle()`. Diffs ----- 3rdparty/libprocess/src/tests/metrics_tests.cpp b84dc8d858f58bc9f52b218b7153510417cf34c2 Diff: https://reviews.apache.org/r/42121/diff/ Testing ------- ./3rdparty/libprocess/libprocess-tests --gtest_filter="MetricsTest.SnapshotTimeout" --gtest_repeat=2000 --gtest_break_on_failure Thanks, Neil Conway
