----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39803/#review114150 -----------------------------------------------------------
Started to look at this review. A few minor comments here, I'll look through the rest tomorrow. 3rdparty/libprocess/3rdparty/stout/include/Makefile.am (line 43) <https://reviews.apache.org/r/39803/#comment174968> Can we add a tab here? 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp (lines 33 - 35) <https://reviews.apache.org/r/39803/#comment174969> What is this for...? 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp (lines 37 - 40) <https://reviews.apache.org/r/39803/#comment174970> We typically don't use typedefs in Mesos. Can we just use `std::shared_ptr<void>`? 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp (lines 156 - 174) <https://reviews.apache.org/r/39803/#comment174971> The parens around `mode` are no longer necessary. 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp (lines 161 - 174) <https://reviews.apache.org/r/39803/#comment174972> Add space before `&`. - Michael Park On Jan. 12, 2016, 2:03 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39803/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2016, 2:03 a.m.) > > > Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van > Remoortere, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Windows: Implemented stout/os/stat.hpp`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp > PRE-CREATION > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/stat.hpp > ffe074830ef90f492990bf695e686c885b9a155c > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp > 5b38b9af654d7d1c574f0cc573083b66693ced1d > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp > d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd > > Diff: https://reviews.apache.org/r/39803/diff/ > > > Testing > ------- > > `make check` from autotools on Ubuntu 15. > `make check` from CMake on OS X 10.10. > Ran `check` project in VS on Windows 10. > > > Thanks, > > Alex Clemmer > >
