> On Jan. 13, 2016, 6:01 a.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am, line 43
> > <https://reviews.apache.org/r/39803/diff/8/?file=1192867#file1192867line43>
> >
> >     Can we add a tab here?

Per our Slack conversation, the length of this path exceeds the length of tabs 
before the `\` character in RB, so let's add a tab here and then I'll follow up 
with a formatting patch to make sure all the other `\` characters line up.


> On Jan. 13, 2016, 6:01 a.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp, lines 33-35
> > <https://reviews.apache.org/r/39803/diff/8/?file=1192872#file1192872line33>
> >
> >     What is this for...?

I've added a comment.


> On Jan. 13, 2016, 6:01 a.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp, lines 37-40
> > <https://reviews.apache.org/r/39803/diff/8/?file=1192872#file1192872line37>
> >
> >     We typically don't use typedefs in Mesos. Can we just use 
> > `std::shared_ptr<void>`?

Per our Slack conversation: (1) I'm all for judicious use of `typedef`, and in 
this case I would really prefer to keep `void *` out of the codebase where 
possible. In Windows we expect to make prodigious use of `shared_handle`, and 
it is (IMHO) dramatically clearer than `shared_ptr<void>`, so I'd humbly like 
to suggest we take an exception here. And (2) regardless, we typedef all over 
the place in `windows.hpp` anyway.

I'm really hoping peopl will agree that this is ok after all. :)


> On Jan. 13, 2016, 6:01 a.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp, lines 156-174
> > <https://reviews.apache.org/r/39803/diff/8/?file=1192872#file1192872line156>
> >
> >     The parens around `mode` are no longer necessary.

I think you meant to turn this from `(((mode) & S_IFMT) == S_IFDIR)` -> 
`((mode) & S_IFMT) == S_IFDIR` rather than to remove the parens around the 
`mode` symbol itself. Let me know if this is not correct.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39803/#review114150
-----------------------------------------------------------


On Jan. 12, 2016, 2:03 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39803/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2016, 2:03 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Implemented stout/os/stat.hpp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp
>  PRE-CREATION 
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/stat.hpp 
> ffe074830ef90f492990bf695e686c885b9a155c 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp 
> 5b38b9af654d7d1c574f0cc573083b66693ced1d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd 
> 
> Diff: https://reviews.apache.org/r/39803/diff/
> 
> 
> Testing
> -------
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Reply via email to