----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42185/#review114160 -----------------------------------------------------------
src/examples/test_http_executor.cpp (line 130) <https://reviews.apache.org/r/42185/#comment174991> Should the parameter be ```const queue<Event>& events"```? src/examples/test_http_executor.cpp (line 140) <https://reviews.apache.org/r/42185/#comment174992> Why do we need the first `endl`? src/examples/test_http_executor.cpp (line 148) <https://reviews.apache.org/r/42185/#comment174993> s/event.launch().task()/task src/examples/test_http_executor.cpp (line 154) <https://reviews.apache.org/r/42185/#comment174994> Here do we need to set task state to `TASK_FINISHED` like test_executor.c? src/examples/test_http_executor.cpp (line 187) <https://reviews.apache.org/r/42185/#comment174995> Suggest to add a `default` case in the end, like: ``` default: { EXIT(1) << "Received an UNKNOWN event"; } ``` - Qian Zhang On Jan. 12, 2016, 5:23 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42185/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2016, 5:23 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-4255 > https://issues.apache.org/jira/browse/MESOS-4255 > > > Repository: mesos > > > Description > ------- > > This change adds a custom executor based on the new executor library. > > > Diffs > ----- > > src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660 > src/examples/test_http_executor.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/42185/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
