> On Jan. 13, 2016, 8:01 a.m., Qian Zhang wrote: > > src/examples/test_http_executor.cpp, line 187 > > <https://reviews.apache.org/r/42185/diff/1/?file=1193986#file1193986line187> > > > > Suggest to add a `default` case in the end, like: > > ``` > > default: { > > EXIT(1) << "Received an UNKNOWN event"; > > } > > ```
We have `-Werror=switch` flags set around compilation that should ensure that compilation should fail if we missed any `case`. Hence, we should be moving away from having the `default` case at all everywhere in our code. > On Jan. 13, 2016, 8:01 a.m., Qian Zhang wrote: > > src/examples/test_http_executor.cpp, line 130 > > <https://reviews.apache.org/r/42185/diff/1/?file=1193986#file1193986line130> > > > > Should the parameter be ```const queue<Event>& events"```? We need to do a `events.pop()` and hence it can't be a constant reference. > On Jan. 13, 2016, 8:01 a.m., Qian Zhang wrote: > > src/examples/test_http_executor.cpp, line 140 > > <https://reviews.apache.org/r/42185/diff/1/?file=1193986#file1193986line140> > > > > Why do we need the first `endl`? Some of the other examples had it. Hence, it got copied over by me. Killed them for now. > On Jan. 13, 2016, 8:01 a.m., Qian Zhang wrote: > > src/examples/test_http_executor.cpp, line 154 > > <https://reviews.apache.org/r/42185/diff/1/?file=1193986#file1193986line154> > > > > Here do we need to set task state to `TASK_FINISHED` like > > test_executor.c? Modified the example to just sending a single terminal update for `TASK_FINISHED`. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42185/#review114160 ----------------------------------------------------------- On Jan. 12, 2016, 9:23 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42185/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2016, 9:23 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-4255 > https://issues.apache.org/jira/browse/MESOS-4255 > > > Repository: mesos > > > Description > ------- > > This change adds a custom executor based on the new executor library. > > > Diffs > ----- > > src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660 > src/examples/test_http_executor.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/42185/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
