> On Jan. 13, 2016, 10:04 a.m., Till Toenshoff wrote: > > bootstrap, line 15 > > <https://reviews.apache.org/r/41243/diff/4/?file=1192325#file1192325line15> > > > > This would introduce Python as a hard dependency of the Mesos build > > environment. > > > > We should avoid this.
If you look back at revision 1, I had a pure bash implemetation of _relpath, but Benjamin Bannier suggested I change it to python since it would be more maintainable. His comments on the matter can be seen above. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/#review114168 ----------------------------------------------------------- On Jan. 11, 2016, 8:12 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41243/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2016, 8:12 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, > Till Toenshoff, and Vinod Kone. > > > Bugs: MESOS-4125 > https://issues.apache.org/jira/browse/MESOS-4125 > > > Repository: mesos > > > Description > ------- > > When building from git, bootstrap will (among other things) install > pre-commit and post-rewrite hooks into the .git/hooks directory of the > mesos tree. However the current implementation always assumes that .git > exists in the same directory as the bootstrap file. This may not always > be true. > > Most notably, it is not true if the mesos tree is included as a > submodule inside another project. When included as a submodule, .git is > no longer a directory, but rather a file whose text contains a pointer > back to the actual location of the .git folder inside the containing > project. To get at this directory, we need to run 'git rev-parse > --git-common-dir' instead of simply assuming that the local .git is the > proper directory. > > Review: https://reviews.apache.org/r/41243 > > > Diffs > ----- > > bootstrap ea71ff22e42bf5e224483508d91c33ddfd350f52 > > Diff: https://reviews.apache.org/r/41243/diff/ > > > Testing > ------- > > Tested on native Mac OS X El Capitan > Tested on vagrant boxes for bento/centos-7.1, ubuntu/trusty64, and > https://github.com/tommy-muehle/puppet-vagrant-boxes/releases/download/1.0.0/centos-6.6-x86_64.box > Also tested on docker image centos:7 > > > Thanks, > > Kevin Klues > >
