----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/#review114398 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/README.md (line 250) <https://reviews.apache.org/r/41593/#comment175233> { on newline. 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp (line 637) <https://reviews.apache.org/r/41593/#comment175236> Are you pulling this variable out to optimize away the calls to `field_count()`? 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp (line 659) <https://reviews.apache.org/r/41593/#comment175235> Why do you need to pull this variable out? 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp (line 699) <https://reviews.apache.org/r/41593/#comment175237> s/str/s/g please. 3rdparty/libprocess/3rdparty/stout/tests/jsonify_tests.cpp (line 85) <https://reviews.apache.org/r/41593/#comment175238> { on newline please (below too). 3rdparty/libprocess/3rdparty/stout/tests/jsonify_tests.cpp (lines 148 - 150) <https://reviews.apache.org/r/41593/#comment175239> :-) !!!!!!!!!!!!!!!!!!!!!! - Benjamin Hindman On Jan. 13, 2016, 12:57 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41593/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2016, 12:57 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 5ab7bc4966fe32eaddd573a4dbfd997f98b5d481 > 3rdparty/libprocess/3rdparty/stout/README.md > a2a3dc6120b10c8fe82088b9f0ebecfa5642f945 > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > ec851dcb08d938defeb6066810011e003d594b29 > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp > 017cef466a30e73af36d72332514a4dbb2beb6bc > 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt > 62ad461eb228b688f1ceac16cfb003561ed5a806 > 3rdparty/libprocess/3rdparty/stout/tests/jsonify_tests.cpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp > 34bb2523ebf3d6d390cbfe1623b89fae0053b712 > > Diff: https://reviews.apache.org/r/41593/diff/ > > > Testing > ------- > > Added tests to `<stout/jsonify_tests.cpp>` > > > Thanks, > > Michael Park > >
