----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42212/#review114539 -----------------------------------------------------------
Patch looks great! Reviews applied: [42053, 42212] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Jan. 14, 2016, 4:11 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42212/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2016, 4:11 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-3307 > https://issues.apache.org/jira/browse/MESOS-3307 > > > Repository: mesos > > > Description > ------- > > This commit adds a unit test to verify that the the max_frameworks and > max_tasks_per_frameworks flags for master work properly. Specifically, > we test to verify that the proper amount of history is maintained for > both 0 values to these flags as well as positive values <= to the total > number of frameworks and tasks per framework actually launched. > > > Diffs > ----- > > src/tests/master_tests.cpp 223b9d20a3a8a8194a3a6a605ec2394c37ab5957 > > Diff: https://reviews.apache.org/r/42212/diff/ > > > Testing > ------- > > This is a unit test. I ran it on my mac and on ubuntu 14.04. > > GTEST_FILTER="MasterTest.MaxCompletedTasksPerFrameworkFlag:MasterTest.MaxCompletedFrameworksFlag" > make check -j 7 > > > Thanks, > > Kevin Klues > >
