> On Jan. 15, 2016, 1:34 a.m., Adam B wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2093-2096 > > <https://reviews.apache.org/r/41672/diff/7/?file=1194005#file1194005line2093> > > > > We rarely (only 67 times) use `unsigned`. Usually it's `int` (909 > > times) for signed values (or values where sign is irrelevant), or > > `uint##_t` for unsigned values of a particular size (e.g. 401 `uint64_t`s). > > Yongqiao Wang wrote: > 'unsigned' is widely used in this file, so I choose to use it to keep > consistence in the same file.
Fair enough. With 15 uses, it's definitely the biggest user of unsigned. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/#review114688 ----------------------------------------------------------- On Jan. 12, 2016, 6:56 a.m., Yongqiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41672/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2016, 6:56 a.m.) > > > Review request for mesos, Adam B, Neil Conway, and Qian Zhang. > > > Bugs: MESOS-4200 > https://issues.apache.org/jira/browse/MESOS-4200 > > > Repository: mesos > > > Description > ------- > > Test case(s) for weights + allocation behavior > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > e044f832c2c16e53e663c6ced5452649bb0dcb59 > > Diff: https://reviews.apache.org/r/41672/diff/ > > > Testing > ------- > > Make check done: > Yongs-MacBook-Pro:build yqwyq$ ./src/mesos-tests > --gtest_filter=HierarchicalAllocatorTest.UpdateWeight > Source directory: /Users/yqwyq/Desktop/mesos > Build directory: /Users/yqwyq/Desktop/mesos/build > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from HierarchicalAllocatorTest > [ RUN ] HierarchicalAllocatorTest.UpdateWeight > [ OK ] HierarchicalAllocatorTest.UpdateWeight (87 ms) > [----------] 1 test from HierarchicalAllocatorTest (87 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (176 ms total) > [ PASSED ] 1 test. > > > Thanks, > > Yongqiao Wang > >
