----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/#review115354 -----------------------------------------------------------
Ship it! Looks great! Doesn't look like you're verifying the first offer cycle in your test, but that should be a quick fix. src/tests/hierarchical_allocator_tests.cpp (line 2222) <https://reviews.apache.org/r/41672/#comment176334> Please add a blank line before this (or any comment line). s/have possessed all resources/sum to the total resources/ src/tests/hierarchical_allocator_tests.cpp (line 2223) <https://reviews.apache.org/r/41672/#comment176335> s/there is/there are/ src/tests/hierarchical_allocator_tests.cpp (lines 2268 - 2269) <https://reviews.apache.org/r/41672/#comment176336> Same as above src/tests/hierarchical_allocator_tests.cpp (line 2312) <https://reviews.apache.org/r/41672/#comment176337> Same as above src/tests/hierarchical_allocator_tests.cpp (lines 2163 - 2167) <https://reviews.apache.org/r/41672/#comment176339> These should be indented 4 spaces instead of 2 src/tests/hierarchical_allocator_tests.cpp (lines 2177 - 2178) <https://reviews.apache.org/r/41672/#comment176341> Where do you verify that role2 doesn't get any offers? Shouldn't you verify that `allocations.get()` returns a single allocation of (6) TOTAL_RESOURCES all associated with role1? - Adam B On Jan. 18, 2016, 12:54 a.m., Yongqiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41672/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2016, 12:54 a.m.) > > > Review request for mesos, Adam B, Neil Conway, and Qian Zhang. > > > Bugs: MESOS-4200 > https://issues.apache.org/jira/browse/MESOS-4200 > > > Repository: mesos > > > Description > ------- > > Test case(s) for weights + allocation behaviour. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 9362dd306497ba01e0f387c3862456cdcac6f863 > > Diff: https://reviews.apache.org/r/41672/diff/ > > > Testing > ------- > > Make check done: > $ ./src/mesos-tests --gtest_filter=HierarchicalAllocatorTest.UpdateWeight > Source directory: /Users/yqwyq/Desktop/mesos > Build directory: /Users/yqwyq/Desktop/mesos/build > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from HierarchicalAllocatorTest > [ RUN ] HierarchicalAllocatorTest.UpdateWeight > [ OK ] HierarchicalAllocatorTest.UpdateWeight (87 ms) > [----------] 1 test from HierarchicalAllocatorTest (87 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (176 ms total) > [ PASSED ] 1 test. > > > Thanks, > > Yongqiao Wang > >
