----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39803/#review114796 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp (lines 96 - 97) <https://reviews.apache.org/r/39803/#comment175652> It seems like we're moving towards `snake_case` for both variable names and function names in stout. Could you update these? Here and below. 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp (line 122) <https://reviews.apache.org/r/39803/#comment175645> Remove newline. 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp (line 238) <https://reviews.apache.org/r/39803/#comment175646> We shouldn't need the cast to `LPDWORD` anymore. 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp (line 79) <https://reviews.apache.org/r/39803/#comment175647> `symlinkHandle->getHandle()` 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp (lines 118 - 119) <https://reviews.apache.org/r/39803/#comment175649> ``` return Error( "Requested mtime for '" + path + "', but symbolic links don't have an mtime on Windows"); ``` - Michael Park On Jan. 15, 2016, 7:21 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39803/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2016, 7:21 p.m.) > > > Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van > Remoortere, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Windows: Implemented stout/os/stat.hpp`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > ec851dcb08d938defeb6066810011e003d594b29 > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp > PRE-CREATION > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/stat.hpp > ffe074830ef90f492990bf695e686c885b9a155c > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp > 5b38b9af654d7d1c574f0cc573083b66693ced1d > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp > 27edf1b4f8647a2720f2962eafa110d694b3baed > > Diff: https://reviews.apache.org/r/39803/diff/ > > > Testing > ------- > > `make check` from autotools on Ubuntu 15. > `make check` from CMake on OS X 10.10. > Ran `check` project in VS on Windows 10. > > > Thanks, > > Alex Clemmer > >
