> On 一月 19, 2016, 11:09 p.m., Joseph Wu wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 1995-1997
> > <https://reviews.apache.org/r/40632/diff/18/?file=1201213#file1201213line1995>
> >
> >     Consider moving this test to after you've implemented optimistic offers 
> > for `Allocator::recoverResources`.

I think that we can keep this test cases which focusing on recovering 
allocation slack. The update for `Allocator::recoverResources` is only used 
when shrinking dynamic reservations, and the allocation slack based on those 
shrinked dynamic reservations are being used by some revocable tasks.

Please refer to https://reviews.apache.org/r/42113/ and 
https://reviews.apache.org/r/42194/ for detail.


> On 一月 19, 2016, 11:09 p.m., Joseph Wu wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 2045-2047
> > <https://reviews.apache.org/r/40632/diff/18/?file=1201213#file1201213line2045>
> >
> >     Consider moving this test to after you've implemented optimistic offers 
> > for `Allocator::recoverResources`.

Same as aobove.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40632/#review115263
-----------------------------------------------------------


On 一月 19, 2016, 8:03 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40632/
> -----------------------------------------------------------
> 
> (Updated 一月 19, 2016, 8:03 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4145
>     https://issues.apache.org/jira/browse/MESOS-4145
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enabled oversubscribed resources for reservations in allocator.
> The allocator part including 5 patches:
> 1) https://reviews.apache.org/r/40632 Enabled oversubscribed resources for 
> reservations in allocator
> 2) https://reviews.apache.org/r/41847 Updated allocation slack when slave was 
> updated.
> 3) https://reviews.apache.org/r/41791 Updated allocation slack for dynamic 
> reserve (1/3).
> 4) https://reviews.apache.org/r/42113 Handle unreserve logic for dynamic 
> reservation (2/3).
> 5) https://reviews.apache.org/r/42194 Handle unreserve logic for dynamic 
> reservation (3/3).
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 48acde69b1a2f305b568a7e322a58708063dd30a 
>   src/tests/hierarchical_allocator_tests.cpp 
> 9362dd306497ba01e0f387c3862456cdcac6f863 
> 
> Diff: https://reviews.apache.org/r/40632/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
> --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Reply via email to