----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/#review115364 -----------------------------------------------------------
src/tests/hierarchical_allocator_tests.cpp (line 2352) <https://reviews.apache.org/r/41672/#comment176348> s/registering/registered/ src/tests/hierarchical_allocator_tests.cpp (lines 2357 - 2358) <https://reviews.apache.org/r/41672/#comment176349> Also `EXPECT_EQ(allocation.get().frameworkId, framework1.id());` and `ASSERT_EQ(6u, allocation.get().resources.size());` to match what you're doing elsewhere. src/tests/hierarchical_allocator_tests.cpp (line 2444) <https://reviews.apache.org/r/41672/#comment176350> s/have possessed all resources/sum to the total resources/ src/tests/hierarchical_allocator_tests.cpp (line 2490) <https://reviews.apache.org/r/41672/#comment176351> s/have possessed all resources/sum to the total resources/ - Adam B On Jan. 19, 2016, 10:49 p.m., Yongqiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41672/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2016, 10:49 p.m.) > > > Review request for mesos, Adam B, Neil Conway, and Qian Zhang. > > > Bugs: MESOS-4200 > https://issues.apache.org/jira/browse/MESOS-4200 > > > Repository: mesos > > > Description > ------- > > Test case(s) for weights + allocation behaviour. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 953712149bd951789beb29c72779c4ac65aa48dc > > Diff: https://reviews.apache.org/r/41672/diff/ > > > Testing > ------- > > Make check done: > $ ./src/mesos-tests --gtest_filter=HierarchicalAllocatorTest.UpdateWeight > Source directory: /Users/yqwyq/Desktop/mesos > Build directory: /Users/yqwyq/Desktop/mesos/build > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from HierarchicalAllocatorTest > [ RUN ] HierarchicalAllocatorTest.UpdateWeight > [ OK ] HierarchicalAllocatorTest.UpdateWeight (87 ms) > [----------] 1 test from HierarchicalAllocatorTest (87 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (176 ms total) > [ PASSED ] 1 test. > > > Thanks, > > Yongqiao Wang > >
