-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41305/#review115703
-----------------------------------------------------------


General questions:

- Besides removing the possibility for overcommit, does this change give us 
anything else?
- What happens if a master sends this modified `TaskInfo` to an agent that does 
not have this chain of patches?
- Have you considered completely converting a `CommandInfo` to `ExecutorInfo`?  
If we do that, it may be possible to remove all the other places with special 
logic for command tasks.


src/master/master.cpp (line 2860)
<https://reviews.apache.org/r/41305/#comment176725>

    `launcher_dir` is an optional field.
    
    Same for the other fields you added (`sandbox_dir`, `switch_user`, 
`executor_rootfs).



src/master/master.cpp (lines 3770 - 3779)
<https://reviews.apache.org/r/41305/#comment176721>

    It should still be invalid to supply both a CommandInfo and ExecutorInfo in 
the same TaskInfo.


- Joseph Wu


On Jan. 18, 2016, 6:55 p.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41305/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2016, 6:55 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Ian 
> Downes, Joris Van Remoortere, Joseph Wu, and Vinod Kone.
> 
> 
> Bugs: MESOS-1718
>     https://issues.apache.org/jira/browse/MESOS-1718
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESOS-1718: move getExecutorInfo from slave to master
> 
> 
> Diffs
> -----
> 
>   src/master/constants.hpp 2c3299bc1aaa0888f7e47a71965c56ada8ecc21f 
>   src/master/master.hpp 3a7e18232323a1c051bcc97915484b1195fffe58 
>   src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422 
>   src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 
>   src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
>   src/slave/slave.cpp bb501810d7bb1261ebbbdd147c49948e5a2f8665 
> 
> Diff: https://reviews.apache.org/r/41305/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Reply via email to