> On Jan. 22, 2016, 5:37 a.m., Joseph Wu wrote:
> > General questions:
> > 
> > - Besides removing the possibility for overcommit, does this change give us 
> > anything else?
> > - What happens if a master sends this modified `TaskInfo` to an agent that 
> > does not have this chain of patches?
> > - Have you considered completely converting a `CommandInfo` to 
> > `ExecutorInfo`?  If we do that, it may be possible to remove all the other 
> > places with special logic for command tasks.
> 
> Klaus Ma wrote:
>     * It's more for evicting executor by master, there's several EPICs about 
> sharing resources between frameworks; and all of them need the feature to let 
> resources owner get resouces back: MESOS-4303 (reclaim/preemption in Mesos), 
> "Optimsitic Offer Phase 2", "Borrow/Lend policy on Quota" (draft idea in my 
> mind)
>     
>     * Good point! If did not get required info, e.g. `launch_dir`, we should 
> keep the same behaviour as before: let salve trace the executor info.
>     
>     * Yes, I'm used to add `taskCommand` into `ExecutorInfo`; but when launch 
> docker executor, it need task info which is different with normal executor. 
> In this patch, I'd like to focus on moving the executor info into master.

@Joseph, any more comments?


- Klaus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41305/#review115703
-----------------------------------------------------------


On Feb. 18, 2016, 7:45 a.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41305/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 7:45 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Joseph Wu.
> 
> 
> Bugs: MESOS-1718
>     https://issues.apache.org/jira/browse/MESOS-1718
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESOS-1718: move getExecutorInfo from slave to master
> 
> 
> Diffs
> -----
> 
>   src/master/constants.hpp 2c3299bc1aaa0888f7e47a71965c56ada8ecc21f 
>   src/master/master.hpp 2f2ad2ada508e1923bf995ab124367a3b082b572 
>   src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 
>   src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 
>   src/slave/slave.hpp ced835dec797bcc5640422468487a4289a737e38 
>   src/slave/slave.cpp f0be0d5bf4b853952caf06e2e262c2903d79ead3 
> 
> Diff: https://reviews.apache.org/r/41305/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Reply via email to