> On Jan. 27, 2016, 3:29 p.m., Jan Schlicht wrote: > > src/authentication/http/authenticator.cpp, lines 58-60 > > <https://reviews.apache.org/r/42603/diff/2/?file=1219238#file1219238line58> > > > > If multiple HTTP authenticators are not supported, why is > > `authenticators` supposed to be a comma separated list of authenticators? > > Calling it `authenticator`, not splitting it and expecting it to be a > > single authenticator would save us from these verifications.
This has been discussed in the past. The idea is to eventually support them. There is already a comment about it in `flags.cpp`. > On Jan. 27, 2016, 3:29 p.m., Jan Schlicht wrote: > > src/master/master.cpp, line 530 > > <https://reviews.apache.org/r/42603/diff/2/?file=1219241#file1219241line530> > > > > Regarding my comment above: Now I see why `authenticators` is a > > comma-seperated list. Because it's taking the `flags.http_authenticators`. > > I'd suggest to do the input validation of these flags here and not in > > `Authenticator` and support only a single authenticator in > > `Authenticator::create`. This is exactly what this patch intends to do, alex-mesos and tillt find that the logic for instantiating `http::Authenticator`s is better located in its on function than here. That's why the `BasicAuthenticatorFactory` is removed in favour of this meta factory. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42603/#review116582 ----------------------------------------------------------- On Jan. 25, 2016, 1:44 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42603/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2016, 1:44 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Jan > Schlicht, and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > Move the code required to instanciate instances of > `process::http::authentication::Authenticator` > in `src/master/main.cpp` to its own factory. > > > Diffs > ----- > > include/mesos/authentication/http/basic_authenticator_factory.hpp > c11bb47c8e02f2e8645cf387d18eb64d1c8cb604 > src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6 > src/authentication/http/authenticator.cpp PRE-CREATION > src/authentication/http/basic_authenticator_factory.cpp > 6eb1c5bd09b136d3bc20481ddcc65cb8bd153682 > src/examples/test_http_authenticator_module.cpp > acf51a6deb8e7dc4ab6ac0cf70380ddbb1839906 > src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422 > src/tests/http_authentication_tests.cpp > bd622576973648e0dfeae1453a5ce631e4171352 > > Diff: https://reviews.apache.org/r/42603/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
