-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42603/#review116641
-----------------------------------------------------------


Fix it, then Ship it!





include/mesos/authentication/http/basic_authenticator_factory.hpp (line 35)
<https://reviews.apache.org/r/42603/#comment177709>

    Not originally yours, but this has to be `virtual` for e.g., 
`CRAMMD5Authenticator`.
    
    Also, I believe we should prefer just `default`ing instead of adding an 
empty body.



include/mesos/authentication/http/basic_authenticator_factory.hpp (line 42)
<https://reviews.apache.org/r/42603/#comment177710>

    Not originally yours, but should probably also be `default`ed.



src/examples/test_http_authenticator_module.cpp (line 28)
<https://reviews.apache.org/r/42603/#comment177713>

    Not yours, but since you are touching most of the code below mind changing 
this to `namespace mesos { ...` (after moving it below the other using decls)?


- Benjamin Bannier


On Jan. 27, 2016, 10:22 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42603/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2016, 10:22 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Jan 
> Schlicht, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Move the code required to instanciate instances of 
> `process::http::authentication::Authenticator`
> in `src/master/main.cpp` to its own factory.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authentication/http/basic_authenticator_factory.hpp 
> c11bb47c8e02f2e8645cf387d18eb64d1c8cb604 
>   src/Makefile.am bdb34020043f64c07721b3e8b29b2cccc21e5b99 
>   src/authentication/http/authenticator.cpp PRE-CREATION 
>   src/authentication/http/basic_authenticator_factory.cpp 
> 6eb1c5bd09b136d3bc20481ddcc65cb8bd153682 
>   src/examples/test_http_authenticator_module.cpp 
> acf51a6deb8e7dc4ab6ac0cf70380ddbb1839906 
>   src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422 
>   src/tests/http_authentication_tests.cpp 
> bd622576973648e0dfeae1453a5ce631e4171352 
> 
> Diff: https://reviews.apache.org/r/42603/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Reply via email to