-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42603/#review116591
-----------------------------------------------------------



Could you separate changes due to `http::Authenticator` and for updating to 
0.28?

- Benjamin Bannier


On Jan. 27, 2016, 4:38 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42603/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2016, 4:38 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Jan 
> Schlicht, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Move the code required to instanciate instances of 
> `process::http::authentication::Authenticator`
> in `src/master/main.cpp` to its own factory.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 
> c20e2ffe128059f9999e63ac2630a2c73e512fc6 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> 4b7d1347f93261df7a7d512721146edca2703b34 
>   3rdparty/libprocess/include/process/gmock.hpp 
> 22a0eac37b16f2ed6afd249f5ea911d81970ba6b 
>   CHANGELOG 78e7796dd8d3727cc456649ddeaf825ffb48808a 
>   CMakeLists.txt d828b754f25803bc3f654aeafa0aec1722dff98b 
>   configure.ac cb39c7f7681eb7f5e3c379dc9a096eca1ffcca93 
>   docs/allocation-module.md 3bbb9045dea2c0e50c4791cc3e220cfe383e0b7b 
>   docs/app-framework-development-guide.md 
> e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
>   docs/authentication.md b40b09eaceddc8e5498b54b3e8ef7a5dbd7b9dc2 
>   docs/c++-style-guide.md 5e2d88d5a7ae06191346bf672f58dbe27b2bccee 
>   docs/clang-format.md 5e720e016ae2635c6a3e1825c0a7fc36f1ef07b7 
>   docs/committers.md 94ee9a6553ad5cd894db6f71825f46a7a3239eb8 
>   docs/containerizer-internals.md 20bf2d16d4f06994ee766a0c15f3528513751efe 
>   docs/containerizer.md cd23cf9c006b862e6e2cf4e215706eff03cd07f8 
>   docs/deploy-scripts.md 87f8eb6254dbf00dc537a180b8d3e0084165d17c 
>   docs/documentation-guide.md b7e861468e8abe1b8e83c115d353e78e601fb41f 
>   docs/effective-code-reviewing.md 5a633bc324290bc1f57884bab550ee9f246f9d0f 
>   docs/fetcher-cache-internals.md 1ccb1c2cbb0a80771f79e98c0bdcc8ee8464ea30 
>   docs/fetcher.md cb4f3c33fb67f7ac65dbe7ebe1347d2599c43f37 
>   docs/high-availability.md 3e9802bd3a2a6f75fff3aea3cfb319adce3271cf 
>   docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec 
>   docs/operational-guide.md 4680ee3397d081acd6f82499703de4456e7ca4f4 
>   docs/quota.md 2762557ad1cec0655a27c4dda4016e07c7f63cd9 
>   docs/sandbox.md 276e1126f495e7af15afd4f4ad8c63beb40db739 
>   docs/tools.md 6234e38c017d8284b2d1a31de63110598c3c60c7 
>   docs/upgrades.md 4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 
>   docs/versioning.md cc31fd53d5bd33168fed0a7c3408616f7c1e9858 
>   include/mesos/authentication/http/basic_authenticator_factory.hpp 
> c11bb47c8e02f2e8645cf387d18eb64d1c8cb604 
>   include/mesos/docker/spec.hpp 6033e824c6f776dc744caf11066b68d3629bb8ca 
>   include/mesos/executor/executor.proto 
> e905a12e88e9a9e1382830974f7b4f82d83be51e 
>   include/mesos/quota/quota.proto 78e12d56c4f41613ec6b731d86093f48a23b4509 
>   include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 
>   include/mesos/scheduler/scheduler.proto 
> 4aa32e6422a458221b7829ec6f5223e6a013feae 
>   include/mesos/v1/executor.hpp adca287be3bb88c8b3298705740cb6bcbb3a09f0 
>   include/mesos/v1/executor/executor.hpp 
> 6e7b41288f44cc1b74b9863407885139f20a379d 
>   include/mesos/v1/executor/executor.proto 
> dbbc2656461e32b47f5c9e2d3767ebdfe343368e 
>   include/mesos/v1/scheduler/scheduler.proto 
> 5d0e6c7dfcdbe004a8629361328287a88d53a1b6 
>   site/Rakefile 0ce4b7975f95ab6930f0b2674191930df9ab5b20 
>   src/Makefile.am bdb34020043f64c07721b3e8b29b2cccc21e5b99 
>   src/authentication/http/authenticator.cpp PRE-CREATION 
>   src/authentication/http/basic_authenticator_factory.cpp 
> 6eb1c5bd09b136d3bc20481ddcc65cb8bd153682 
>   src/common/resources.cpp 588a279c3cdebbeb58047bfbff5e78a42f53fc13 
>   src/common/roles.cpp 65c71931a5645d346439c3cdff1c5c8cc3ee01a3 
>   src/examples/docker_no_executor_framework.cpp 
> cf7b4e1b4a27a3a6d484b1e205b5ca1c3ec583e1 
>   src/examples/load_generator_framework.cpp 
> 7d64b6617564f43ef383ee60d92da92b2c958c47 
>   src/examples/test_http_authenticator_module.cpp 
> acf51a6deb8e7dc4ab6ac0cf70380ddbb1839906 
>   src/executor/executor.cpp 92334ffb8af83b1c86c44bd406147893c7c6daa3 
>   src/jvm/jvm.cpp 909d34a0112b219456dce76126029c603077e66d 
>   src/master/allocator/mesos/hierarchical.hpp 
> 1f0c440565ee0f9926d168734df30fd740a53f88 
>   src/master/allocator/mesos/hierarchical.cpp 
> dbc77a2d0ce797eea2287b0242f5d2da81c16455 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 4669149b81de39b4bb921ef7cd6787aa583f6e40 
>   src/master/allocator/sorter/drf/sorter.cpp 
> 1f39f6d12cb2673ef4b75c3efb23ca5f7dbbf29a 
>   src/master/allocator/sorter/sorter.hpp 
> a0a779b81f6d048271f15256b38ff907ae144b83 
>   src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422 
>   src/master/quota.hpp 3cb194aa9f032d5d18cb2dcc09c672b11e8d56eb 
>   src/master/quota.cpp e7ce0f1fc1c83b2ec30185db005d2671a93baed6 
>   src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08 
>   src/sched/sched.cpp 8e51752536041b896e42d44e6e9eae909b0a1d68 
>   src/slave/container_loggers/lib_logrotate.hpp 
> 8c5602da3e5ff7bcf758da61723b7a0ea00a6a6e 
>   src/slave/container_loggers/logrotate.hpp 
> 16d92322079a69d8e6bed7830623c62f345cd51c 
>   src/slave/container_loggers/logrotate.cpp 
> 7d36c052ff7a180b45ca265fb7ff4c6900d98d64 
>   src/slave/containerizer/containerizer.cpp 
> 59904684cdeb17ef2b42092a3558802c42bfb6bd 
>   src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9 
>   src/slave/containerizer/mesos/isolators/posix/disk.hpp 
> 5607c0f43084f491e4927f5c6ec283210aa5f355 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 
> d5bf8c10b9cfb360a7856144d59ce89060de5c99 
>   src/tests/container_logger_tests.cpp 
> 5fe9cce97ee83d6a9e272879ec0395b5ace4a491 
>   src/tests/containerizer.hpp bd9ee2c189b774979095f8483b4e9ba41a7bdb24 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 645bdcf095145097d8b8c65d592c787417883145 
>   src/tests/containerizer/docker_tests.cpp 
> f0ad20e5a8252ad761e8fa42724caed31b8fae9d 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> 8bc2e1de8c1d39a945ebb9f730cedab771b89070 
>   src/tests/disk_quota_tests.cpp eb93c2fc4a791fdb8a61e4c539fa85ece7c5604e 
>   src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c 
>   src/tests/hierarchical_allocator_tests.cpp 
> f18e6eb10572b0f5b8bbff338384d9406f6ad62b 
>   src/tests/hook_tests.cpp 1a1bab49469485887e0a6a8fa1837bd70262d3b5 
>   src/tests/http_authentication_tests.cpp 
> bd622576973648e0dfeae1453a5ce631e4171352 
>   src/tests/master_quota_tests.cpp 04efcf3362d3594e0ad8077793fa1f32536dd658 
>   src/tests/mesos.hpp 845b637c765b5b97568e9b3797b53814d2ab7782 
>   src/tests/role_tests.cpp fc3a72894631279460ee7971a4627d73c3d8c351 
>   src/v1/resources.cpp fc7c885b4dc7f961bde9d97818db7d066c81860a 
> 
> Diff: https://reviews.apache.org/r/42603/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Reply via email to