-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42955/#review117021
-----------------------------------------------------------



Looks good, would be great if you could get some feedback from michael park on 
the gcc bug you encountered.


3rdparty/libprocess/include/process/collect.hpp (lines 43 - 44)
<https://reviews.apache.org/r/42955/#comment178079>

    s/TYPES/Ts/ here and below



3rdparty/libprocess/include/process/collect.hpp (lines 217 - 225)
<https://reviews.apache.org/r/42955/#comment178090>

    This looks ok to me, but could you ping mpark to see if he has any feedback 
on this?



3rdparty/libprocess/include/process/collect.hpp (line 223)
<https://reviews.apache.org/r/42955/#comment178089>

    s/func/f/


- Ben Mahler


On Jan. 29, 2016, 9:18 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42955/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2016, 9:18 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-4551
>     https://issues.apache.org/jira/browse/MESOS-4551
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, templates only existed to allow collect to take either a
> std::list of Futures, or *exactly* 2 Futures as arguments.
> 
> This commit removes the 2 argument template and replaces it with a
> variadic template that accepts an arbitrary number of Futures as
> arguments.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/collect.hpp 
> cd78b6c211c2e4ca2b1ebbe728cfc2dfad1a32c9 
> 
> Diff: https://reviews.apache.org/r/42955/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Reply via email to