----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42955/#review117060 -----------------------------------------------------------
LGTM, but it would be nice to include a pointer to the GCC bug (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47226) and probably also the workaround more prominently. - Benjamin Bannier On Jan. 29, 2016, 11:34 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42955/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2016, 11:34 p.m.) > > > Review request for mesos, Jie Yu, Joris Van Remoortere, and Michael Park. > > > Bugs: MESOS-4551 > https://issues.apache.org/jira/browse/MESOS-4551 > > > Repository: mesos > > > Description > ------- > > Previously, templates only existed to allow collect to take either a > std::list of Futures, or *exactly* 2 Futures as arguments. > > This commit removes the 2 argument template and replaces it with a > variadic template that accepts an arbitrary number of Futures as > arguments. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/collect.hpp > cd78b6c211c2e4ca2b1ebbe728cfc2dfad1a32c9 > > Diff: https://reviews.apache.org/r/42955/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Klues > >
