----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43096/#review117539 -----------------------------------------------------------
src/linux/cgroups.hpp (line 655) <https://reviews.apache.org/r/43096/#comment178750> We don't add extra indentation here. Please take a look at the code around you:) src/linux/cgroups.hpp (line 658) <https://reviews.apache.org/r/43096/#comment178762> 2 lines apart. src/linux/cgroups.cpp (line 2459) <https://reviews.apache.org/r/43096/#comment178751> Add one extra line here. src/linux/cgroups.cpp (lines 2466 - 2481) <https://reviews.apache.org/r/43096/#comment178753> indentation should be 2 here. src/linux/cgroups.cpp (line 2467) <https://reviews.apache.org/r/43096/#comment178755> s/handle/read/ src/linux/cgroups.cpp (lines 2469 - 2471) <https://reviews.apache.org/r/43096/#comment178757> ``` return Error("Unable to read 'net_cls.classid':" + read.error()); ``` The caller is responsible for printing the cgroup/hierarchy. src/linux/cgroups.cpp (line 2474) <https://reviews.apache.org/r/43096/#comment178758> s/iHandle/handle/ src/linux/cgroups.cpp (lines 2476 - 2478) <https://reviews.apache.org/r/43096/#comment178759> ``` return Error("Not a valid number"); ``` src/linux/cgroups.cpp (lines 2483 - 2484) <https://reviews.apache.org/r/43096/#comment178752> one extra line here. src/linux/cgroups.cpp (line 2489) <https://reviews.apache.org/r/43096/#comment178760> Where is the stringify function? Have you verified that if we can just write a decimal number to net_cls.classid, or it has to be a hex number? src/linux/cgroups.cpp (lines 2501 - 2503) <https://reviews.apache.org/r/43096/#comment178761> ``` return Error("Failed to write 'net_cls.classid': " + write.error()); ``` - Jie Yu On Feb. 3, 2016, 12:47 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43096/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2016, 12:47 a.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Added helper function in cgroup for supporting net_cls subsystem. > > > Diffs > ----- > > src/linux/cgroups.hpp 83b3e401ac69194bef496087dee32e0532b834ab > src/linux/cgroups.cpp bbc1fb3c60e53dffb1e8029942725e7102eb9aee > > Diff: https://reviews.apache.org/r/43096/diff/ > > > Testing > ------- > > make and make check. > > > Thanks, > > Avinash sridharan > >
