-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43096/#review117644
-----------------------------------------------------------




src/linux/cgroups.hpp (lines 656 - 657)
<https://reviews.apache.org/r/43096/#comment178904>

    I would still use multiple lines here because the code surrounding uses the 
same pattern. we value consistency in our code base.
    
    The indentation here is not correct. I'll let you find out by looking at 
the surrounding code.



src/linux/cgroups.hpp (lines 662 - 664)
<https://reviews.apache.org/r/43096/#comment178905>

    Ditto on indentation.



src/linux/cgroups.cpp (line 2488)
<https://reviews.apache.org/r/43096/#comment178908>

    Have you checked out the impl. of 'stringify'? Does it return a 'Try'?


- Jie Yu


On Feb. 3, 2016, 7:17 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43096/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2016, 7:17 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added helper function in cgroup for supporting net_cls subsystem.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.hpp 83b3e401ac69194bef496087dee32e0532b834ab 
>   src/linux/cgroups.cpp bbc1fb3c60e53dffb1e8029942725e7102eb9aee 
> 
> Diff: https://reviews.apache.org/r/43096/diff/
> 
> 
> Testing
> -------
> 
> make and make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Reply via email to