> On Feb. 3, 2016, 1:32 a.m., Jie Yu wrote: > > src/linux/cgroups.cpp, line 2489 > > <https://reviews.apache.org/r/43096/diff/3/?file=1230206#file1230206line2489> > > > > Where is the stringify function? > > > > Have you verified that if we can just write a decimal number to > > net_cls.classid, or it has to be a hex number?
Hi Jie, Tried it out. We can write a decimal number direclty. The stringify is the stout::stringify function. It was being used here as well: https://github.com/apache/mesos/blob/765c025dd43e04360b29c19bd9a66837954c5a20/src/linux/cgroups.cpp#L960 I couldn't find an overloaded cgorups::write that took the value as an int, and hence had to stringify before using cgroups::write - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43096/#review117539 ----------------------------------------------------------- On Feb. 3, 2016, 7:17 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43096/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2016, 7:17 a.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Added helper function in cgroup for supporting net_cls subsystem. > > > Diffs > ----- > > src/linux/cgroups.hpp 83b3e401ac69194bef496087dee32e0532b834ab > src/linux/cgroups.cpp bbc1fb3c60e53dffb1e8029942725e7102eb9aee > > Diff: https://reviews.apache.org/r/43096/diff/ > > > Testing > ------- > > make and make check. > > > Thanks, > > Avinash sridharan > >
