> On Feb. 4, 2016, 7:21 p.m., Jie Yu wrote:
> > src/tests/containerizer/isolator_tests.cpp, lines 374-395
> > <https://reviews.apache.org/r/42588/diff/10/?file=1232270#file1232270line374>
> >
> >     Hum, I don't think this test fixture is needed. Just create 
> > handleManager in each test.
> >     
> >     ```
> >     NetClsHandleManager manager(
> >         (Bound<uint16_t>::closed(2),
> >          Bound<uint16_t>::closed(3));
> >          
> >     for (int primary = 2; primary <= 3; primary++) {
> >       ...
> >     }
> >     
> >     for (int primary = 2; primary <= 3; primary++) {
> >       ...
> >     }
> >     ```

Couldn't use (Bound<uint16_t>::closed(2),
     Bound<uint16_t>::closed(3) had to use 
Intervalset<uint16_t>((Bound<uint16_t>::closed(2),
     Bound<uint16_t>::closed(3))


> On Feb. 4, 2016, 7:21 p.m., Jie Yu wrote:
> > src/tests/containerizer/isolator_tests.cpp, lines 411-412
> > <https://reviews.apache.org/r/42588/diff/10/?file=1232270#file1232270line411>
> >
> >     These two can be combined into:
> >     ```
> >     EXPECT_SOME_TRUE(manager->isUsed(handle.get());
> >     ```

Thanks !! Simplified.


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42588/#review117857
-----------------------------------------------------------


On Feb. 4, 2016, 9:03 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42588/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2016, 9:03 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4345
>     https://issues.apache.org/jira/browse/MESOS-4345
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added unit-test for `NetClsHandleManager`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
> b4bc52114389d1c1efce2830f4292bd89bb0de7c 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
> ddc1bf0939e5e8995e6f34fe7b8509b51704f63e 
>   src/tests/containerizer/isolator_tests.cpp 
> 8d101df957fd36adac388310eddba2db1f98c029 
> 
> Diff: https://reviews.apache.org/r/42588/diff/
> 
> 
> Testing
> -------
> 
> make and make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Reply via email to