----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42588/#review117914 -----------------------------------------------------------
Fix it, then Ship it! src/tests/containerizer/isolator_tests.cpp (line 374) <https://reviews.apache.org/r/42588/#comment179172> You don't need to inherit from MesosTest for this. Just inherit from ::testing::Test src/tests/containerizer/isolator_tests.cpp (lines 377 - 379) <https://reviews.apache.org/r/42588/#comment179170> Can you move this, along with NetClsIsolatorTest to a separate file (e.g., cgroups_net_cls_isolator_tests.cpp) src/tests/containerizer/isolator_tests.cpp (line 382) <https://reviews.apache.org/r/42588/#comment179173> IntervalSet<uint16_t> here is not needed. Just do ``` NetClsHandleManager manager( (Bound<uint16_t>::closed(3), Bound<uint16_t>::closed(3)); ``` src/tests/containerizer/isolator_tests.cpp (line 405) <https://reviews.apache.org/r/42588/#comment179174> Ditto. src/tests/containerizer/isolator_tests.cpp (line 417) <https://reviews.apache.org/r/42588/#comment179175> Ditto. - Jie Yu On Feb. 4, 2016, 9:03 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42588/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2016, 9:03 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4345 > https://issues.apache.org/jira/browse/MESOS-4345 > > > Repository: mesos > > > Description > ------- > > Added unit-test for `NetClsHandleManager`. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp > b4bc52114389d1c1efce2830f4292bd89bb0de7c > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp > ddc1bf0939e5e8995e6f34fe7b8509b51704f63e > src/tests/containerizer/isolator_tests.cpp > 8d101df957fd36adac388310eddba2db1f98c029 > > Diff: https://reviews.apache.org/r/42588/diff/ > > > Testing > ------- > > make and make check. > > > Thanks, > > Avinash sridharan > >
