> On Feb. 5, 2016, 12:04 a.m., Jie Yu wrote:
> > src/tests/containerizer/isolator_tests.cpp, line 382
> > <https://reviews.apache.org/r/42588/diff/11/?file=1233122#file1233122line382>
> >
> >     IntervalSet<uint16_t> here is not needed. Just do
> >     
> >     ```
> >     NetClsHandleManager manager(
> >         (Bound<uint16_t>::closed(3),
> >          Bound<uint16_t>::closed(3));
> >          
> >     
> >     ```

As discussed need IntervalSet<uint16_t> due to explicit constructor in 
IntervalSet


> On Feb. 5, 2016, 12:04 a.m., Jie Yu wrote:
> > src/tests/containerizer/isolator_tests.cpp, line 405
> > <https://reviews.apache.org/r/42588/diff/11/?file=1233122#file1233122line405>
> >
> >     Ditto.

Same reason as above.


> On Feb. 5, 2016, 12:04 a.m., Jie Yu wrote:
> > src/tests/containerizer/isolator_tests.cpp, line 417
> > <https://reviews.apache.org/r/42588/diff/11/?file=1233122#file1233122line417>
> >
> >     Ditto.

Same reason as above.


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42588/#review117914
-----------------------------------------------------------


On Feb. 4, 2016, 9:03 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42588/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2016, 9:03 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4345
>     https://issues.apache.org/jira/browse/MESOS-4345
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added unit-test for `NetClsHandleManager`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
> b4bc52114389d1c1efce2830f4292bd89bb0de7c 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
> ddc1bf0939e5e8995e6f34fe7b8509b51704f63e 
>   src/tests/containerizer/isolator_tests.cpp 
> 8d101df957fd36adac388310eddba2db1f98c029 
> 
> Diff: https://reviews.apache.org/r/42588/diff/
> 
> 
> Testing
> -------
> 
> make and make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Reply via email to