----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41288/#review118299 -----------------------------------------------------------
src/tests/mesos.hpp (line 937) <https://reviews.apache.org/r/41288/#comment179521> s/executor/_executor/ src/tests/mesos.hpp (line 943) <https://reviews.apache.org/r/41288/#comment179522> put the second argument on next line for consistency. also pass "this" as the 3rd argument for consistency with connected callback. src/tests/mesos.hpp (line 960) <https://reviews.apache.org/r/41288/#comment179520> s/executor_/executor/ we typically don't use underscores for member variables. src/tests/mesos.hpp (line 965) <https://reviews.apache.org/r/41288/#comment179524> do you need executor::TestMesos even though you are in executor namespace? - Vinod Kone On Feb. 4, 2016, 11:11 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41288/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2016, 11:11 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-4433 > https://issues.apache.org/jira/browse/MESOS-4433 > > > Repository: mesos > > > Description > ------- > > This change introduces a versioned callback interface for testing HTTP based > executors. The reasoning is similar to `MESOS-3339` , the corresponding issue > for Schedulers. > > > Diffs > ----- > > src/tests/mesos.hpp c2bae4767ee7372c796bfad44ed1e86db7dd3488 > > Diff: https://reviews.apache.org/r/41288/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
