----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41288/#review118340 -----------------------------------------------------------
Fix it, then Ship it! src/tests/mesos.hpp (line 948) <https://reviews.apache.org/r/41288/#comment179564> looks like you forgot to pass "this" to this callback? - Vinod Kone On Feb. 9, 2016, 12:12 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41288/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2016, 12:12 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-4433 > https://issues.apache.org/jira/browse/MESOS-4433 > > > Repository: mesos > > > Description > ------- > > This change introduces a versioned callback interface for testing HTTP based > executors. The reasoning is similar to `MESOS-3339` , the corresponding issue > for Schedulers. > > > Diffs > ----- > > src/tests/mesos.hpp e07d8aa6f1e507a91ce70763aafa134bdd9a7ec8 > > Diff: https://reviews.apache.org/r/41288/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
