> On Feb. 8, 2016, 10 p.m., Vinod Kone wrote: > > src/tests/mesos.hpp, line 960 > > <https://reviews.apache.org/r/41288/diff/3/?file=1233179#file1233179line960> > > > > s/executor_/executor/ > > > > we typically don't use underscores for member variables.
Our style guide does recommend to prefer trailing underscores for member variables. From the style guide: ``` Prefer trailing underscores for use as member fields (but not required). ``` I removed the trailing underscores for now since all the other classes/structs in this file do not use it. > On Feb. 8, 2016, 10 p.m., Vinod Kone wrote: > > src/tests/mesos.hpp, line 965 > > <https://reviews.apache.org/r/41288/diff/3/?file=1233179#file1233179line965> > > > > do you need executor::TestMesos even though you are in executor > > namespace? Yep, right. My bad, fixed. :-) - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41288/#review118299 ----------------------------------------------------------- On Feb. 8, 2016, 10:15 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41288/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2016, 10:15 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-4433 > https://issues.apache.org/jira/browse/MESOS-4433 > > > Repository: mesos > > > Description > ------- > > This change introduces a versioned callback interface for testing HTTP based > executors. The reasoning is similar to `MESOS-3339` , the corresponding issue > for Schedulers. > > > Diffs > ----- > > src/tests/mesos.hpp e07d8aa6f1e507a91ce70763aafa134bdd9a7ec8 > > Diff: https://reviews.apache.org/r/41288/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
