----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/#review118617 -----------------------------------------------------------
Looks good, but I think we can pull this information into the roles.md and endpoint help docs, rather than create a new docs page. docs/weights.md (line 5) <https://reviews.apache.org/r/42719/#comment179904> Why not just include this in the existing roles.md? If you are creating a new doc, you ought to add it to home.md so it can easily be found and navigated to. docs/weights.md (line 9) <https://reviews.apache.org/r/42719/#comment179905> s/0.26/0.27/ s/specify/specifying/ docs/weights.md (line 10) <https://reviews.apache.org/r/42719/#comment179906> s/, if/. If/ docs/weights.md (line 11) <https://reviews.apache.org/r/42719/#comment179907> "If a role does not have a weight specified in the --weights flag, ..." docs/weights.md (lines 12 - 13) <https://reviews.apache.org/r/42719/#comment179908> Weights cannot be changed without updating the flag and restarting all Mesos masters. docs/weights.md (line 15) <https://reviews.apache.org/r/42719/#comment179909> s/0.27/0.28/ s/involved, and .../introduced so an operator can update weights at runtime./ docs/weights.md (line 19) <https://reviews.apache.org/r/42719/#comment179911> I wonder if all this information should just go in the endpoint help description, and then you can link to it in the new auto-generated endpoints docs, e.g. http://mesos.apache.org/documentation/latest/endpoints/master/roles/ docs/weights.md (line 55) <https://reviews.apache.org/r/42719/#comment179910> s/include// - Adam B On Jan. 25, 2016, 7 a.m., Yongqiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42719/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2016, 7 a.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-3945 > https://issues.apache.org/jira/browse/MESOS-3945 > > > Repository: mesos > > > Description > ------- > > Add doc for weights. > > > Diffs > ----- > > docs/weights.md PRE-CREATION > > Diff: https://reviews.apache.org/r/42719/diff/ > > > Testing > ------- > > > Thanks, > > Yongqiao Wang > >
